adjusting code

DFE-Digital · Feb 7, 2024 · 7ca964e · 7ca964e
1 parent 7abf2d7
commit 7ca964e
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 7 deletions.
diff --git a/app/views/teacher_interface/application_forms/show/_declined.html.erb b/app/views/teacher_interface/application_forms/show/_declined.html.erb
@@ -14,12 +14,14 @@
   <% else %>
     <ul class="govuk-list govuk-list--bullet">
       <% reasons.each do |reason| %>
-        <li><%= simple_format reason %></li>
-          <% parts = reason.split("\n\n") %>
-          <% if parts.size > 1 %>
-            <h4 class="govuk-heading-s">Assessor Notes</h4>
-            <li><%= simple_format parts[1] %></li>
-          <% end %>  
+        <% parts = reason.split("\n\n") %>
+        <% decline_reason = parts[0] %>
+        <% assessor_note = parts[1] %>
+        <li><%= simple_format decline_reason %></li>
+        <% if assessor_note.present? %>
+          <h4 class="govuk-heading-s">Assessor notes</h4>
+          <li><%= simple_format assessor_note %></li>
+        <% end %>
       <% end %>
     </ul>
   <% end %>

diff --git a/app/views/teacher_mailer/application_declined.text.erb b/app/views/teacher_mailer/application_declined.text.erb
@@ -19,9 +19,10 @@ Thank you for applying for qualified teacher status (QTS) and for your patience
 
 <%= decline_reason %>
 
+<% if assessor_note.present? %>
 ## <%= note_title %>
-
 <%= assessor_note %>
+<% end %>
 
 <% end %>
 <% end %>