Skip to content

Commit

Permalink
Merge pull request #2544 from DFE-Digital/AQTS-688-dev-code-architect…
Browse files Browse the repository at this point in the history
…ure-update-delete-dqt-match-column

[AQTS-688] Remove dqt_match column in favour of trs_match which has already been deployed
  • Loading branch information
Hassanmir92 authored Dec 5, 2024
2 parents 2d36619 + d162135 commit 61e931d
Show file tree
Hide file tree
Showing 9 changed files with 8 additions and 8 deletions.
1 change: 0 additions & 1 deletion app/models/application_form.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# confirmed_no_sanctions :boolean default(FALSE)
# date_of_birth :date
# declined_at :datetime
# dqt_match :jsonb
# english_language_citizenship_exempt :boolean
# english_language_proof_method :string
# english_language_provider_other :boolean default(FALSE), not null
Expand Down
1 change: 0 additions & 1 deletion config/analytics.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
- created_at
- date_of_birth
- declined_at
- dqt_match
- english_language_citizenship_exempt
- english_language_proof_method
- english_language_provider_id
Expand Down
1 change: 0 additions & 1 deletion config/analytics_hidden_pii.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
- family_name
- given_names
- registration_number
- dqt_match
- trs_match
:assessments:
- recommendation_assessor_note
Expand Down
7 changes: 7 additions & 0 deletions db/migrate/20241203141754_drop_column_for_dqt_match.rb
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
# frozen_string_literal: true

class DropColumnForDQTMatch < ActiveRecord::Migration[7.2]
def change
remove_column :application_forms, :dqt_match, :jsonb, default: {}
end
end
3 changes: 1 addition & 2 deletions db/schema.rb

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion db/scripts/sanitise.sql
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ SET
date_of_birth = '2000-01-01',
alternative_given_names = '',
alternative_family_name = '',
dqt_match = '{}',
trs_match = '{}',
registration_number = '';

Expand Down
Binary file modified docs/diagram.pdf
Binary file not shown.
1 change: 0 additions & 1 deletion spec/factories/application_forms.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# confirmed_no_sanctions :boolean default(FALSE)
# date_of_birth :date
# declined_at :datetime
# dqt_match :jsonb
# english_language_citizenship_exempt :boolean
# english_language_proof_method :string
# english_language_provider_other :boolean default(FALSE), not null
Expand Down
1 change: 0 additions & 1 deletion spec/models/application_form_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@
# confirmed_no_sanctions :boolean default(FALSE)
# date_of_birth :date
# declined_at :datetime
# dqt_match :jsonb
# english_language_citizenship_exempt :boolean
# english_language_proof_method :string
# english_language_provider_other :boolean default(FALSE), not null
Expand Down

0 comments on commit 61e931d

Please sign in to comment.