Merge pull request #2259 from DFE-Digital/already-received-consent

Skip submission page if consent already received
DFE-Digital · Jun 14, 2024 · 5f76019 · 5f76019
2 parents e182141 + 143e2e7
commit 5f76019
Showing 1 changed file with 11 additions and 3 deletions.
diff --git a/app/controllers/teacher_interface/consent_requests_controller.rb b/app/controllers/teacher_interface/consent_requests_controller.rb
@@ -20,10 +20,18 @@ def check
     end
 
     def submit
+      consent_requests = application_form.assessment.consent_requests
+
+      if consent_requests.all?(&:received?)
+        redirect_to %i[teacher_interface application_form]
+      end
+
       ActiveRecord::Base.transaction do
-        application_form.assessment.consent_requests.each do |requestable|
-          ReceiveRequestable.call(requestable:, user: current_teacher)
-        end
+        consent_requests
+          .reject(&:received?)
+          .each do |requestable|
+            ReceiveRequestable.call(requestable:, user: current_teacher)
+          end
       end
 
       DeliverEmail.call(