Change state default

This sets a default on the database so we don't need to set one when we stop using the field.
DFE-Digital · Sep 29, 2023 · 500c896 · 500c896
1 parent 522cbe4
commit 500c896
Show file tree

Hide file tree

Showing 14 changed files with 37 additions and 17 deletions.
diff --git a/app/models/further_information_request.rb b/app/models/further_information_request.rb
@@ -9,7 +9,7 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           not null
+#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

diff --git a/app/models/professional_standing_request.rb b/app/models/professional_standing_request.rb
@@ -13,7 +13,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/app/models/qualification_request.rb b/app/models/qualification_request.rb
@@ -12,7 +12,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/app/models/reference_request.rb b/app/models/reference_request.rb
@@ -31,7 +31,7 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           not null
+#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null

diff --git a/db/migrate/20230926142509_change_requestables_state_default.rb b/db/migrate/20230926142509_change_requestables_state_default.rb
@@ -0,0 +1,20 @@
+class ChangeRequestablesStateDefault < ActiveRecord::Migration[7.0]
+  def change
+    change_column_default :further_information_requests,
+                          :state,
+                          from: nil,
+                          to: "requested"
+    change_column_default :professional_standing_requests,
+                          :state,
+                          from: nil,
+                          to: "requested"
+    change_column_default :qualification_requests,
+                          :state,
+                          from: nil,
+                          to: "requested"
+    change_column_default :reference_requests,
+                          :state,
+                          from: nil,
+                          to: "requested"
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/spec/factories/further_information_requests.rb b/spec/factories/further_information_requests.rb
@@ -11,7 +11,7 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           not null
+#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

diff --git a/spec/factories/professional_standing_requests.rb b/spec/factories/professional_standing_requests.rb
@@ -13,7 +13,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/spec/factories/qualification_requests.rb b/spec/factories/qualification_requests.rb
@@ -12,7 +12,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/spec/factories/reference_requests.rb b/spec/factories/reference_requests.rb
@@ -31,7 +31,7 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           not null
+#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null

diff --git a/spec/models/further_information_request_spec.rb b/spec/models/further_information_request_spec.rb
@@ -11,7 +11,7 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           not null
+#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

diff --git a/spec/models/professional_standing_request_spec.rb b/spec/models/professional_standing_request_spec.rb
@@ -13,7 +13,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/spec/models/qualification_request_spec.rb b/spec/models/qualification_request_spec.rb
@@ -12,7 +12,7 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           not null
+#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

diff --git a/spec/models/reference_request_spec.rb b/spec/models/reference_request_spec.rb
@@ -31,7 +31,7 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           not null
+#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null