Fixed failing tests and made suggested changes

DFE-Digital · Oct 16, 2023 · 43ed120 · 43ed120
1 parent 63210e7
commit 43ed120
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 11 deletions.
diff --git a/app/views/assessor_interface/further_information_requests/preview.html.erb b/app/views/assessor_interface/further_information_requests/preview.html.erb
@@ -15,15 +15,15 @@
     <section class="app-further-information-request-item">
       <h2 class="govuk-heading-s">Reason for request</h2>
       <% if items.size == 1 %>
-        <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %></p>
-      <% elsif items.size > 1 %>
+        <p class="govuk-body">We were unable to verify the details for <%= items.first.work_history.school_name %>.</p>
+      <% else %>
         <p class="govuk-body">We were unable to verify the details for:</p>
         <ul class="govuk-list govuk-list--bullet">
           <% items.each do |item| %>
             <li><%= item.work_history.school_name %></li>
           <% end %>
         </ul>
-      <%end%>
+      <% end %>
       <h2 class="govuk-heading-s">Note to applicant</h2>
 
       <%= govuk_inset_text do %>
@@ -33,7 +33,7 @@
   <% else %>
     <% items.each do |item| %>
       <section class="app-further-information-request-item">
-        <h3 class="govuk-heading-s"><%= t(item.failure_reason_key, scope: %i[assessor_interface assessment_sections failure_reasons as_statement]) %></h3>
+        <p class="govuk-body"><%= t(item.failure_reason_key, scope: %i[assessor_interface assessment_sections failure_reasons as_statement]) %></p>
 
         <h2 class="govuk-heading-s">Note to applicant</h2>
 

diff --git a/spec/system/assessor_interface/requesting_further_information_spec.rb b/spec/system/assessor_interface/requesting_further_information_spec.rb
@@ -75,9 +75,7 @@ def when_i_select_request_further_information
 
   def and_i_see_the_further_information_request_items
     expect(assessor_request_further_information_page.items.count).to eq(1)
-    expect(
-      assessor_request_further_information_page.items.first.heading.text,
-    ).to eq(
+    expect(assessor_request_further_information_page).to have_content(
       "Subjects entered are acceptable for QTS, but the uploaded qualifications do not match them.",
     )
     expect(

diff --git a/spec/system/teacher_interface/further_information_spec.rb b/spec/system/teacher_interface/further_information_spec.rb
@@ -159,9 +159,7 @@ def and_i_see_the_check_your_answers_items
     expect(rows.first.key.text).to eq(
       "Tell us more about the subjects you can teach",
     )
-    expect(rows.second.key.text).to eq(
-      "Add your work history contact’s details",
-    )
+    expect(rows.second.key.text).to eq("Add work history details")
 
     expect(rows.last.key.text).to eq("Upload your identity document")
   end
@@ -233,7 +231,7 @@ def text_check_answers_item
 
   def work_history_task_list_item
     teacher_further_information_requested_page.task_list.find_item(
-      "Add your work history contact’s details",
+      "Add work history details",
     )
   end