Merge pull request #2211 from DFE-Digital/fix-incorrect-submission

Check assessment subjects rather than applicant subjects
DFE-Digital · May 16, 2024 · 4217219 · 4217219
2 parents 6f5cea2 + fac2df9
commit 4217219
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/app/lib/analytics/publication_extract.rb b/app/lib/analytics/publication_extract.rb
@@ -18,7 +18,10 @@ def call
       declines = declined_application_forms(country)
       withdraws = withdrawn_application_forms(country)
 
-      submissions_with_subjects = submissions.where.not(subjects: [])
+      submissions_with_subjects =
+        submissions.select do |application_form|
+          application_form.assessment&.subjects.present?
+        end
 
       induction_required =
         awards