removed redundent code and added default to helper method

DFE-Digital · Nov 6, 2023 · 3b0cef4 · 3b0cef4
1 parent d377a83
commit 3b0cef4
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 7 deletions.
diff --git a/app/controllers/assessor_interface/review_verifications_controller.rb b/app/controllers/assessor_interface/review_verifications_controller.rb
@@ -2,7 +2,6 @@
 
 module AssessorInterface
   class ReviewVerificationsController < BaseController
-    include RegionHelper
     before_action :authorize_assessor
 
     def index

diff --git a/app/helpers/region_helper.rb b/app/helpers/region_helper.rb
@@ -11,8 +11,8 @@ def region_certificate_phrase(region)
     "#{certificate.indefinite_article} #{tag.span(certificate, lang: region.country.code)}".html_safe
   end
 
-  def region_teaching_authority_name(region)
-    region.teaching_authority_name.presence || "teaching authority"
+  def region_teaching_authority_name(region, default = nil)
+    region.teaching_authority_name.presence || default || "teaching authority"
   end
 
   def region_teaching_authority_name_phrase(region)

diff --git a/app/views/assessor_interface/review_verifications/index.html.erb b/app/views/assessor_interface/review_verifications/index.html.erb
@@ -14,7 +14,7 @@
         title: "LoPS",
         items: [
           {
-            name: (region_teaching_authority_name(@application_form.region) == "teaching authority") ? "Contact relevant competent authority" : region_teaching_authority_name(@application_form.region),
+            name: region_teaching_authority_name(@application_form.region, "Contact relevant competent authority"),
             link: [:review, :assessor_interface, @application_form, @assessment, :professional_standing_request],
             status: @professional_standing_request.review_status,
           }

diff --git a/spec/support/autoload/page_objects/task_list.rb b/spec/support/autoload/page_objects/task_list.rb
@@ -1,8 +1,5 @@
 module PageObjects
   class TaskList < SitePrism::Section
-    element :not_started_status, ".govuk-tag.govuk-tag--grey"
-    element :accepted_status, ".govuk-tag.govuk-tag--green"
-
     sections :sections, TaskListSection, ".app-task-list > li"
 
     def find_item(text)