Update teacher work history duration calculation

This updates the calculation to consider the qualification certificate date compared to the start date of the work history when calculating it.
DFE-Digital · Nov 22, 2023 · 3a33ac4 · 3a33ac4
1 parent 3e0ea0e
commit 3a33ac4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 4 deletions.
diff --git a/app/controllers/teacher_interface/work_histories_controller.rb b/app/controllers/teacher_interface/work_histories_controller.rb
@@ -258,7 +258,10 @@ def work_history_contact_form_params
 
     def load_months_count
       @months_count =
-        WorkHistoryDuration.for_application_form(application_form).count_months
+        WorkHistoryDuration.for_application_form(
+          application_form,
+          consider_teaching_qualification: true,
+        ).count_months
     end
 
     def check_member_identifier

diff --git a/app/lib/application_form_section_status_updater.rb b/app/lib/application_form_section_status_updater.rb
@@ -143,10 +143,12 @@ def work_history_status
       return :in_progress unless all_work_histories_complete
 
       months_count =
-        WorkHistoryDuration.for_application_form(application_form).count_months
-      return :in_progress unless months_count >= 9
+        WorkHistoryDuration.for_application_form(
+          application_form,
+          consider_teaching_qualification: true,
+        ).count_months
 
-      :completed
+      months_count >= 9 ? :completed : :in_progress
     else
       return :not_started if has_work_history.nil?