Merge pull request #2141 from DFE-Digital/remove-upload-default

Don't set a default upload filename
DFE-Digital · Apr 11, 2024 · 3249594 · 3249594
2 parents ee78795 + 6809e82
commit 3249594
Show file tree

Hide file tree

Showing 7 changed files with 10 additions and 18 deletions.
diff --git a/app/models/upload.rb b/app/models/upload.rb
@@ -3,7 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
-#  filename            :string           default(""), not null
+#  filename            :string           not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null

diff --git a/db/migrate/20240410151207_change_upload_filename_default.rb b/db/migrate/20240410151207_change_upload_filename_default.rb
@@ -0,0 +1,5 @@
+class ChangeUploadFilenameDefault < ActiveRecord::Migration[7.1]
+  def change
+    change_column_default :uploads, :filename, from: "", to: nil
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/lib/tasks/uploads.rake b/lib/tasks/uploads.rake
diff --git a/spec/factories/uploads.rb b/spec/factories/uploads.rb
@@ -3,7 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
-#  filename            :string           default(""), not null
+#  filename            :string           not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null

diff --git a/spec/fixtures/files/translation_upload.pdf b/spec/fixtures/files/translation_upload.pdf
diff --git a/spec/models/upload_spec.rb b/spec/models/upload_spec.rb
@@ -3,7 +3,7 @@
 # Table name: uploads
 #
 #  id                  :bigint           not null, primary key
-#  filename            :string           default(""), not null
+#  filename            :string           not null
 #  malware_scan_result :string           default("pending"), not null
 #  translation         :boolean          not null
 #  created_at          :datetime         not null