Run linter

This corrects a number of linting issues in the new version of Rubocop.
DFE-Digital · Dec 21, 2023 · 299535e · 299535e
1 parent f34ee4e
commit 299535e
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 10 deletions.
diff --git a/app/forms/concerns/assessor_interface/updates_english_language_status.rb b/app/forms/concerns/assessor_interface/updates_english_language_status.rb
@@ -17,10 +17,8 @@ def initial_attributes(assessment_section)
 
         super.merge(
           english_language_section_passed:
-            (
-              english_language_section(assessment)&.passed &&
-                application_form.send(self::EXEMPTION_ATTR)
-            ),
+            english_language_section(assessment)&.passed &&
+              application_form.send(self::EXEMPTION_ATTR),
         )
       end
 

diff --git a/app/jobs/fetch_malware_scan_results_job.rb b/app/jobs/fetch_malware_scan_results_job.rb
@@ -5,6 +5,6 @@ def perform
     Upload
       .where(malware_scan_result: "pending")
       .where("created_at < ?", 5.minutes.ago)
-      .each { |upload| FetchMalwareScanResult.call(upload:) }
+      .find_each { |upload| FetchMalwareScanResult.call(upload:) }
   end
 end
diff --git a/app/lib/application_form_status_updater.rb b/app/lib/application_form_status_updater.rb
@@ -248,7 +248,7 @@ def needs_references_verified?
 
   def further_information_requests
     @further_information_requests ||=
-      assessment&.further_information_requests&.to_a || []
+      assessment&.further_information_requests.to_a
   end
 
   def professional_standing_requests
@@ -258,11 +258,11 @@ def professional_standing_requests
   end
 
   def qualification_requests
-    @qualification_requests ||= assessment&.qualification_requests&.to_a || []
+    @qualification_requests ||= assessment&.qualification_requests.to_a
   end
 
   def reference_requests
-    @reference_requests ||= assessment&.reference_requests&.to_a || []
+    @reference_requests ||= assessment&.reference_requests.to_a
   end
 
   def overdue?(requestables:)

diff --git a/db/migrate/20220908064656_add_rules_to_application_forms.rb b/db/migrate/20220908064656_add_rules_to_application_forms.rb
@@ -8,7 +8,7 @@ def change
 
     ApplicationForm
       .includes(:region)
-      .each do |application_form|
+      .find_each do |application_form|
         region = application_form.region
 
         application_form.update!(

diff --git a/lib/tasks/example_data.rake b/lib/tasks/example_data.rake
@@ -223,7 +223,7 @@ def create_requestables(application_form, assessment, state)
 end
 
 def create_application_forms
-  Region.all.each do |region|
+  Region.all.find_each do |region|
     application_form_traits_for(region).each do |traits|
       application_form = FactoryBot.create(:application_form, *traits, region:)