Remove ready_for_review column

It's not being used anywhere so we can remove this column.
DFE-Digital · Nov 8, 2023 · 1d1e0f3 · 1d1e0f3
1 parent 7b679a7
commit 1d1e0f3
Show file tree

Hide file tree

Showing 6 changed files with 54 additions and 48 deletions.
diff --git a/app/models/professional_standing_request.rb b/app/models/professional_standing_request.rb
@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #

diff --git a/config/analytics.yml b/config/analytics.yml
@@ -218,7 +218,6 @@
     - expired_at
     - id
     - location_note
-    - ready_for_review
     - received_at
     - requested_at
     - review_note

diff --git a/db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb b/db/migrate/20231011121802_remove_ready_for_review_from_professional_standing_requests.rb
@@ -0,0 +1,11 @@
+class RemoveReadyForReviewFromProfessionalStandingRequests < ActiveRecord::Migration[
+  7.1
+]
+  def change
+    remove_column :professional_standing_requests,
+                  :ready_for_review,
+                  :boolean,
+                  null: false,
+                  default: false
+  end
+end
diff --git a/db/schema.rb b/db/schema.rb
diff --git a/spec/factories/professional_standing_requests.rb b/spec/factories/professional_standing_requests.rb
@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #

diff --git a/spec/models/professional_standing_request_spec.rb b/spec/models/professional_standing_request_spec.rb
@@ -4,21 +4,20 @@
 #
 # Table name: professional_standing_requests
 #
-#  id               :bigint           not null, primary key
-#  expired_at       :datetime
-#  location_note    :text             default(""), not null
-#  ready_for_review :boolean          default(FALSE), not null
-#  received_at      :datetime
-#  requested_at     :datetime
-#  review_note      :string           default(""), not null
-#  review_passed    :boolean
-#  reviewed_at      :datetime
-#  verified_at      :datetime
-#  verify_note      :text             default(""), not null
-#  verify_passed    :boolean
-#  created_at       :datetime         not null
-#  updated_at       :datetime         not null
-#  assessment_id    :bigint           not null
+#  id            :bigint           not null, primary key
+#  expired_at    :datetime
+#  location_note :text             default(""), not null
+#  received_at   :datetime
+#  requested_at  :datetime
+#  review_note   :string           default(""), not null
+#  review_passed :boolean
+#  reviewed_at   :datetime
+#  verified_at   :datetime
+#  verify_note   :text             default(""), not null
+#  verify_passed :boolean
+#  created_at    :datetime         not null
+#  updated_at    :datetime         not null
+#  assessment_id :bigint           not null
 #
 # Indexes
 #