Remove state column

This removes the column from all the requestables as we're no longer
using it for anything and it can be safely removed.

app/models/further_information_request.rb

@@ -9,7 +9,6 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

app/models/professional_standing_request.rb

@@ -13,7 +13,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

app/models/qualification_request.rb

@@ -12,7 +12,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

app/models/reference_request.rb

@@ -31,7 +31,6 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null

config/analytics.yml

@@ -184,7 +184,6 @@
     - received_at
     - requested_at
     - reviewed_at
-    - state
     - updated_at
     - working_days_assessment_started_to_creation
     - working_days_received_to_recommendation
@@ -221,7 +220,6 @@
     - received_at
     - requested_at
     - reviewed_at
-    - state
     - updated_at
   :qualifications:
     - id
@@ -247,7 +245,6 @@
     - received_at
     - requested_at
     - reviewed_at
-    - state
     - updated_at
   :reference_requests:
     - additional_information_response
@@ -279,7 +276,6 @@
     - satisfied_comment
     - satisfied_response
     - slug
-    - state
     - updated_at
     - work_history_id
   :regions:

db/migrate/20230926162102_remove_state_from_requestables.rb

@@ -0,0 +1,24 @@
+class RemoveStateFromRequestables < ActiveRecord::Migration[7.0]
+  def change
+    remove_column :further_information_requests,
+                  :state,
+                  type: :string,
+                  null: false,
+                  default: "requested"
+    remove_column :professional_standing_requests,
+                  :state,
+                  type: :string,
+                  null: false,
+                  default: "requested"
+    remove_column :qualification_requests,
+                  :state,
+                  type: :string,
+                  null: false,
+                  default: "requested"
+    remove_column :reference_requests,
+                  :state,
+                  type: :string,
+                  null: false,
+                  default: "requested"
+  end
+end

spec/factories/further_information_requests.rb

@@ -11,7 +11,6 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

spec/factories/professional_standing_requests.rb

@@ -13,7 +13,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

spec/factories/qualification_requests.rb

@@ -12,7 +12,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

spec/factories/reference_requests.rb

@@ -31,7 +31,6 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null

spec/forms/assessor_interface/professional_standing_request_location_form_spec.rb

@@ -66,10 +66,6 @@
 
       it { is_expected.to be true }
 
-      it "doesn't change the state" do
-        expect { save }.to_not change(requestable, :state)
-      end
-
       it "sets ready for review" do
         expect { save }.to change(requestable, :ready_for_review).to(true)
       end
@@ -81,10 +77,6 @@
 
       it { is_expected.to be true }
 
-      it "doesn't change the state" do
-        expect { save }.to_not change(requestable, :state)
-      end
-
       it "doesn't set ready for review" do
         expect { save }.to_not change(requestable, :ready_for_review)
       end

spec/forms/assessor_interface/qualification_request_form_spec.rb

@@ -126,10 +126,6 @@
 
       it { is_expected.to be true }
 
-      it "doesn't change the state" do
-        expect { save }.to_not change(requestable, :state)
-      end
-
       it "sets passed" do
         expect { save }.to change(requestable, :passed).to(false)
       end
@@ -149,10 +145,6 @@
 
       it { is_expected.to be true }
 
-      it "doesn't change the state" do
-        expect { save }.to_not change(requestable, :state)
-      end
-
       it "doesn't set passed" do
         expect { save }.to_not change(requestable, :passed)
       end

spec/models/further_information_request_spec.rb

@@ -11,7 +11,6 @@
 #  received_at                                 :datetime
 #  requested_at                                :datetime
 #  reviewed_at                                 :datetime
-#  state                                       :string           default("requested"), not null
 #  working_days_assessment_started_to_creation :integer
 #  working_days_received_to_recommendation     :integer
 #  working_days_since_received                 :integer

spec/models/professional_standing_request_spec.rb

@@ -13,7 +13,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

spec/models/qualification_request_spec.rb

@@ -12,7 +12,6 @@
 #  received_at           :datetime
 #  requested_at          :datetime
 #  reviewed_at           :datetime
-#  state                 :string           default("requested"), not null
 #  created_at            :datetime         not null
 #  updated_at            :datetime         not null
 #  assessment_id         :bigint           not null

spec/models/reference_request_spec.rb

@@ -31,7 +31,6 @@
 #  satisfied_comment               :text             default(""), not null
 #  satisfied_response              :boolean
 #  slug                            :string           not null
-#  state                           :string           default("requested"), not null
 #  created_at                      :datetime         not null
 #  updated_at                      :datetime         not null
 #  assessment_id                   :bigint           not null