Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/services strategy pattern #675

Merged
merged 4 commits into from
Jan 22, 2025
Merged

Feature/services strategy pattern #675

merged 4 commits into from
Jan 22, 2025
+74 −24

Conversation

alexluckett
Copy link
Contributor

Cherry picked from DEFRA/forms-runner-v2#1

alexluckett
alexluckett commented Jan 22, 2025
View reviewed changes
Copy link
Contributor Author

@alexluckett alexluckett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Dave's code

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
95.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alexluckett alexluckett merged commit 2f193fe into main Jan 22, 2025
10 checks passed
@alexluckett alexluckett deleted the feature/services-strategy-pattern branch January 22, 2025 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidjamesstone davidjamesstone davidjamesstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexluckett @davidjamesstone