feature/485768 page conditions

[davidjamesstone]

No description provided.

[alexluckett]

Looking good. If this gets more complicated, we should look at splitting out our v1/v2 engine logic into separate encapsulated functions and using something like the strategy pattern to switch between the logic for engine v1/v2 depending on the form definition's engine version.

e.g.

engineStrategies.js

class EngineStrategyV1 {
    getNextPath(defaultPath) { }
    // anything else we need
}

class EngineStrategyV2 {
    getNextPath(defaultPath) { }
    // anything else we need
}

QuestionPageController.ts

getNextPath(context: FormContext) {
    const { model, next, path } = this
    const { evaluationState } = context
    const summaryPath = this.getSummaryPath()
    const statusPath = this.getStatusPath()

    // Walk from summary page (no next links) to status page
    let defaultPath = path === summaryPath ? statusPath : undefined

    return engineStrategy.getNextPath() // engineStrategy would be passed in ideally as a dependency in the constructor
}

questionPageController = new QuestionPageController(engineStrategy) // engineStrategy is either EngineStrategyV1 or EngineStrategyV2 based on model.engine

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
92.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[alexluckett]

Nice 👌