improvements around registerPlayback

[gechoto]

What is it?

• New feature (user facing)
• Update to existing feature (user facing)
• Bugfix (user facing)
• Translations
• Codebase improvements or refactors (dev facing)
• Other

Description of the changes in your PR

• Use playback tracking url from database if it exists (as before 3767b06)
• Only call registerPlayback if the playback tracking url is not null
• Report exceptions in case registerPlayback ran into an error

Due diligence

• I read the contribution guidelines.
• I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

[gechoto]

@mikooomich with 3767b06 you changed it so that it always makes a new player request before registering playback.

This leads to duplicate/more requests being made and the playbackUrl from the database (added here:

OuterTune/app/src/main/java/com/dd3boh/outertune/playback/MusicService.kt

Line 737 in 78b0ae5

playbackUrl = playbackData.playbackTracking?.videostatsPlaybackUrl?.baseUrl

) seems to be unused now.

Was there a reason for this change?

In case the additional player requests are required now every time the playbackUrl should be removed from the database instead.

[gechoto]

btw there could be more improvements later.

• if the playback tracking url is kept in the database: rename it (the current name playbackUrl sounds like a streaming url, something like playbackTrackingUrl would be easier to understand)
• validate playback tracking urls before making the requests (maybe throw exception if it does not start with "https://s.youtube.com")

[mikooomich]

) seems to be unused now.
Was there a reason for this change?

I didn't realize this was saved. Thanks!

if the playback tracking url is kept in the database: rename it (the current name playbackUrl sounds like a streaming url, something like playbackTrackingUrl would be easier to understand)

I'll keep this in mine next time we need to update the database schema