player: when playback error because no connection, stop song and show loading. When connection back, resume playing

[mattcarter11]

What is it?

• New feature (user facing)
• Update to existing feature (user facing)
• Bugfix (user facing)
• Translations
• Codebase improvements or refactors (dev facing)
• Other

Description of the changes in your PR

• add logic to handle error when no connection
• expose flag when player is waiting for connection
• add logic to resume playing on connection
• add error message when this happens

Before/After Screenshots/Screen Record

• Before: Nothing
• After: Changing mode from the player (or settings) -> Show what mode you have changed

• Before: Nothing
• After: On error -> display what the player does (according to your settings)

Closes #181

Due diligence

• I read the contribution guidelines.
• I understand that in the event of merge conflicts, I may be asked to rebase my branch on top of the dev branch, instead of resolving them by merging dev into my own branch

[mikooomich]

@mattcarter11 There are some weirdness with this implementation. LMK what you think of my changes (in the last commit)

[mattcarter11]

mm.... when I did this it was because I thought it would be better to allow the user to choose what to do on error.
Having by default on connection error wait for reconnection I think is fine. But enabling the user to choose skip and then have it's behavior stop I find weird.

Maybe we should just remove the setting and leave the original logic with the wait on connection error logic before.

[mikooomich]

Alright, sounds good, lmk when you've got that sorted out. Just to confirm, wait to reconnect becomes it's own toggle on/off, and skip remains an on/off?

(Also apologies for the conflicts I caused with your prs. I could rebase for you but that mucks with authorship, I'm not sure what your preferences are)

[mattcarter11]

I meant no toggles at all.

When on error, if it's connection related, wait to reconnect, if not do the old skip twice then pause.

[mattcarter11]

@mikooomich all done

[mikooomich]

@mattcarter11 sorry for bothering you again, there are some nasty conflicts with visible offline 2.0 that I'm not too sure what happened. Please take a look when convenient

[mattcarter11]

I'll open the pr once all fixed