Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ranking bar graphs #5997

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Ranking bar graphs #5997

wants to merge 15 commits into from
+294 −66

Conversation

shawnyama
Copy link
Contributor

@shawnyama shawnyama commented Jan 9, 2025 •
edited
Loading

Description

  • ranking bar graphs based on criteria of interest
  • ranking results graph on the top adds all the bars below together

image

@shawnyama shawnyama marked this pull request as ready for review January 9, 2025 22:12
@shawnyama shawnyama linked an issue Jan 9, 2025 that may be closed by this pull request
[FEAT]: New 'Compare simulations' operator #5703
Open
mloppie
mloppie reviewed Jan 9, 2025
View reviewed changes
packages/client/hmi-client/src/services/charts.ts
{
mark: {
type: 'text',
align: 'right',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could align: 'left' fix the text to the bottom of the bar?

Base automatically changed from start-ranking-interventions to main January 10, 2025 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mloppie mloppie mloppie left review comments

@YohannParis YohannParis Awaiting requested review from YohannParis YohannParis is a code owner

@mwdchang mwdchang Awaiting requested review from mwdchang mwdchang is a code owner

@jryu01 jryu01 Awaiting requested review from jryu01 jryu01 is a code owner

@Tom-Szendrey Tom-Szendrey Awaiting requested review from Tom-Szendrey Tom-Szendrey is a code owner

@blanchco blanchco Awaiting requested review from blanchco blanchco is a code owner

@asylves1 asylves1 Awaiting requested review from asylves1 asylves1 is a code owner

@dgauldie dgauldie Awaiting requested review from dgauldie dgauldie is a code owner

@dvince2 dvince2 Awaiting requested review from dvince2 dvince2 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEAT]: New 'Compare simulations' operator
2 participants
@shawnyama @mloppie