Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple Choice Veto #777

Merged
merged 9 commits into from
Dec 4, 2023
Merged

Multiple Choice Veto #777

merged 9 commits into from
Dec 4, 2023

Conversation

NoahSaso
Copy link
Member

@NoahSaso NoahSaso commented Dec 2, 2023

This PR applies the same changes as #752 to the dao-proposal-multiple contract, adding support for the veto feature from #736.

Copy link

codecov bot commented Dec 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6b228ce) 96.37% compared to head (2d333ae) 96.45%.

❗ Current head 2d333ae differs from pull request most recent head 986e8e0. Consider uploading reports for the commit 986e8e0 to get more accurate results

Files Patch % Lines
...cts/proposal/dao-proposal-multiple/src/contract.rs 97.77% 2 Missing ⚠️
...l/dao-proposal-multiple/src/testing/instantiate.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             veto     #777      +/-   ##
==========================================
+ Coverage   96.37%   96.45%   +0.07%     
==========================================
  Files         204      204              
  Lines       51133    52354    +1221     
==========================================
+ Hits        49281    50499    +1218     
- Misses       1852     1855       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…voting_period, and fixed tests. Also fixed missing timelock status handler.
@NoahSaso NoahSaso merged commit 37ebd9d into veto Dec 4, 2023
6 of 7 checks passed
@NoahSaso NoahSaso deleted the noah/veto-multi branch December 4, 2023 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants