-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiple Choice Veto #777
Merged
Merged
Multiple Choice Veto #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/veto-multi
branch
from
December 2, 2023 22:46
bed6292
to
da1e70e
Compare
NoahSaso
force-pushed
the
noah/veto-multi
branch
from
December 2, 2023 22:51
da1e70e
to
6b0aa22
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## veto #777 +/- ##
==========================================
+ Coverage 96.37% 96.45% +0.07%
==========================================
Files 204 204
Lines 51133 52354 +1221
==========================================
+ Hits 49281 50499 +1218
- Misses 1852 1855 +3 ☔ View full report in Codecov by Sentry. |
JakeHartnell
approved these changes
Dec 4, 2023
…voting_period, and fixed tests. Also fixed missing timelock status handler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the same changes as #752 to the
dao-proposal-multiple
contract, adding support for the veto feature from #736.