Added missing completed proposal queries to approval-single #767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSaso
force-pushed
the
noah/missing-approval-query
branch
2 times, most recently
from
69d8e27
to
bd7b3cc
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development #767 +/- ##
==============================================
Coverage ? 96.27%
==============================================
Files ? 203
Lines ? 50289
Branches ? 0
==============================================
Hits ? 48414
Misses ? 1875
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…eated proposal ID when approved.
NoahSaso
force-pushed
the
noah/missing-approval-query
branch
from
bd7b3cc
to
671c0c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
dao-pre-propose-approval-singlecontract does not store pending proposals once they have been approved or rejected. This makes it impossible to retrieve past decisions and connect approval proposals used indao-pre-propose-approverto existing proposals.This PR adds queries to check whether or not a given approval ID is pending, and allows querying completed proposals. If approved, it also includes the created proposal ID. It also adds a query to get the completed pre-propose ID from the created proposal ID.