-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Audit Fixes and Improvements #742
Commits on Sep 3, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4b1398c - Browse repository at this point
Copy the full SHA 4b1398cView commit details -
Configuration menu - View commit details
-
Copy full SHA for de50a62 - Browse repository at this point
Copy the full SHA de50a62View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbad6e7 - Browse repository at this point
Copy the full SHA fbad6e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2a50a0b - Browse repository at this point
Copy the full SHA 2a50a0bView commit details -
Configuration menu - View commit details
-
Copy full SHA for cdb8da2 - Browse repository at this point
Copy the full SHA cdb8da2View commit details -
Fix Stargaze collection info bug, and absolute count validation
sg721 has two addresses that control it. The `minter` which can mint NFTs, and the `creator` which can update collection metadata and royalties. We now set both of those to be the DAO.
Configuration menu - View commit details
-
Copy full SHA for 74420d1 - Browse repository at this point
Copy the full SHA 74420d1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 583db0c - Browse repository at this point
Copy the full SHA 583db0cView commit details -
Configuration menu - View commit details
-
Copy full SHA for c82fdd3 - Browse repository at this point
Copy the full SHA c82fdd3View commit details -
Configuration menu - View commit details
-
Copy full SHA for d3ad487 - Browse repository at this point
Copy the full SHA d3ad487View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6cf16d - Browse repository at this point
Copy the full SHA c6cf16dView commit details -
Configuration menu - View commit details
-
Copy full SHA for c02a52a - Browse repository at this point
Copy the full SHA c02a52aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 56159d2 - Browse repository at this point
Copy the full SHA 56159d2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27c1602 - Browse repository at this point
Copy the full SHA 27c1602View commit details -
Configuration menu - View commit details
-
Copy full SHA for 89cf32b - Browse repository at this point
Copy the full SHA 89cf32bView commit details -
Better API for cw-tokenfactory-issuer
Many of these methods are not needed thanks to Authz.
Configuration menu - View commit details
-
Copy full SHA for 8bcae64 - Browse repository at this point
Copy the full SHA 8bcae64View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b75780 - Browse repository at this point
Copy the full SHA 3b75780View commit details -
Configuration menu - View commit details
-
Copy full SHA for ce4e4fc - Browse repository at this point
Copy the full SHA ce4e4fcView commit details -
Configuration menu - View commit details
-
Copy full SHA for df1591b - Browse repository at this point
Copy the full SHA df1591bView commit details -
Configuration menu - View commit details
-
Copy full SHA for bfff543 - Browse repository at this point
Copy the full SHA bfff543View commit details -
Configuration menu - View commit details
-
Copy full SHA for 360297a - Browse repository at this point
Copy the full SHA 360297aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 527a600 - Browse repository at this point
Copy the full SHA 527a600View commit details -
Configuration menu - View commit details
-
Copy full SHA for b4256b1 - Browse repository at this point
Copy the full SHA b4256b1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2781cec - Browse repository at this point
Copy the full SHA 2781cecView commit details -
Configuration menu - View commit details
-
Copy full SHA for f96e6e4 - Browse repository at this point
Copy the full SHA f96e6e4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 17928bc - Browse repository at this point
Copy the full SHA 17928bcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 51c79c0 - Browse repository at this point
Copy the full SHA 51c79c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f20b1cb - Browse repository at this point
Copy the full SHA f20b1cbView commit details -
Configuration menu - View commit details
-
Copy full SHA for dc48b30 - Browse repository at this point
Copy the full SHA dc48b30View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2b04dbc - Browse repository at this point
Copy the full SHA 2b04dbcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e48211f - Browse repository at this point
Copy the full SHA e48211fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 426d139 - Browse repository at this point
Copy the full SHA 426d139View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2c230d - Browse repository at this point
Copy the full SHA c2c230dView commit details
Commits on Sep 5, 2023
-
Improve unstaking_duration validation reuse
Jake Hartnell committedSep 5, 2023 Configuration menu - View commit details
-
Copy full SHA for 318cea5 - Browse repository at this point
Copy the full SHA 318cea5View commit details -
Allowlist should apply to transfers from *or to* an address
For example, a DAO may wish to white list a Token Staking contract (to allow users to stake their tokens in the DAO) or a Merkle Drop contract (to allow users to claim their tokens).
Configuration menu - View commit details
-
Copy full SHA for 8c1b31f - Browse repository at this point
Copy the full SHA 8c1b31fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8883b75 - Browse repository at this point
Copy the full SHA 8883b75View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8683f4 - Browse repository at this point
Copy the full SHA a8683f4View commit details -
Remove commented out metadata test
Osmosis test tube doesn't support metadata queries anymore, we assume metadata is set properly by the Cosmos SDK and this is well tested upstream.
Configuration menu - View commit details
-
Copy full SHA for 2cb2d59 - Browse repository at this point
Copy the full SHA 2cb2d59View commit details -
More informative error to address BlockBeforeSend hook executing on m…
…inting or burning This is intended functionality. If a token is frozen, a DAO needs to both grant a minter allowance as well as adding the minter to the allowlist to allow for token transfers when the token is frozen. The new error message should make next steps clear if this edge case is encountered.
Configuration menu - View commit details
-
Copy full SHA for f2d4ac3 - Browse repository at this point
Copy the full SHA f2d4ac3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5953169 - Browse repository at this point
Copy the full SHA 5953169View commit details -
Configuration menu - View commit details
-
Copy full SHA for dd93317 - Browse repository at this point
Copy the full SHA dd93317View commit details -
Make it possible to unset BeforeSendHook, or set to a different contract
DAOs may wish to disable the BeforeSendHook at some point, or potentially set it to a custom cosmwasm contract if they wish to customize functionality a bit more. Modifies the SetBeforeSendHook method to allow for this, and adds tests that it's indeed possible to set it to nil.
Configuration menu - View commit details
-
Copy full SHA for 7633b3e - Browse repository at this point
Copy the full SHA 7633b3eView commit details -
Default to BeforeSendHook features being disabled
These are powerful features, but many may not want them as they can be abused. DAOs that want these features will have to explicitly enable them via a governance prop.
Configuration menu - View commit details
-
Copy full SHA for 0115fe7 - Browse repository at this point
Copy the full SHA 0115fe7View commit details
Commits on Sep 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dc7af3c - Browse repository at this point
Copy the full SHA dc7af3cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 508d81c - Browse repository at this point
Copy the full SHA 508d81cView commit details
Commits on Sep 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 8c54bf2 - Browse repository at this point
Copy the full SHA 8c54bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa1a74a - Browse repository at this point
Copy the full SHA fa1a74aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 71137e8 - Browse repository at this point
Copy the full SHA 71137e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for b6f9c04 - Browse repository at this point
Copy the full SHA b6f9c04View commit details -
Configuration menu - View commit details
-
Copy full SHA for c46597e - Browse repository at this point
Copy the full SHA c46597eView commit details -
Configuration menu - View commit details
-
Copy full SHA for cc764d0 - Browse repository at this point
Copy the full SHA cc764d0View commit details
Commits on Sep 11, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 87aaf6d - Browse repository at this point
Copy the full SHA 87aaf6dView commit details -
Remove owner from dao-voting-cw721-staked
The concept of ownership doesn't really make sense for voting contracts. IMO the owner should always be the DAO.
Configuration menu - View commit details
-
Copy full SHA for 21e91ee - Browse repository at this point
Copy the full SHA 21e91eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2d40452 - Browse repository at this point
Copy the full SHA 2d40452View commit details
Commits on Sep 12, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 4778813 - Browse repository at this point
Copy the full SHA 4778813View commit details -
Configuration menu - View commit details
-
Copy full SHA for c232173 - Browse repository at this point
Copy the full SHA c232173View commit details -
Configuration menu - View commit details
-
Copy full SHA for be1ae92 - Browse repository at this point
Copy the full SHA be1ae92View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1c51285 - Browse repository at this point
Copy the full SHA 1c51285View commit details -
Configuration menu - View commit details
-
Copy full SHA for 26e24dd - Browse repository at this point
Copy the full SHA 26e24ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for 67e8b83 - Browse repository at this point
Copy the full SHA 67e8b83View commit details