Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Audit Fixes and Improvements #742

Merged
merged 59 commits into from
Sep 15, 2023
Merged

Audit Fixes and Improvements #742

merged 59 commits into from
Sep 15, 2023

Commits on Sep 3, 2023

  1. Configuration menu
    Copy the full SHA
    4b1398c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    de50a62 View commit details
    Browse the repository at this point in the history
  3. Fix absoluteCount can be configured to be greater than the total

    NFT supply
    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    fbad6e7 View commit details
    Browse the repository at this point in the history
  4. Fix absoluteCount threshold for a new token is not validated

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    2a50a0b View commit details
    Browse the repository at this point in the history
  5. Fix issuer contract can be blacklisted

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    cdb8da2 View commit details
    Browse the repository at this point in the history
  6. Fix Stargaze collection info bug, and absolute count validation

    sg721 has two addresses that control it. The `minter` which can mint
    NFTs, and the `creator` which can update collection metadata and
    royalties.
    
    We now set both of those to be the DAO.
    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    74420d1 View commit details
    Browse the repository at this point in the history
  7. Fix incorrect events are emitted for whitelist

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    583db0c View commit details
    Browse the repository at this point in the history
  8. Fix lack of denom validation

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c82fdd3 View commit details
    Browse the repository at this point in the history
  9. Fix BEFORE_SEND_HOOK_FEATURES_ENABLED is not exposed through smart qu…

    …eries
    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    d3ad487 View commit details
    Browse the repository at this point in the history
  10. Fix misleading from attribute when burning funds

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c6cf16d View commit details
    Browse the repository at this point in the history
  11. Fix broken tests from denom validation

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    c02a52a View commit details
    Browse the repository at this point in the history
  12. Fix inconsistent attribute namings and orderings

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    56159d2 View commit details
    Browse the repository at this point in the history
  13. Fix INITITIAL_NFTS spelling XD

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    27c1602 View commit details
    Browse the repository at this point in the history
  14. Fix counterintuitive variable namings

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    89cf32b View commit details
    Browse the repository at this point in the history
  15. Better API for cw-tokenfactory-issuer

    Many of these methods are not needed thanks to Authz.
    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    8bcae64 View commit details
    Browse the repository at this point in the history
  16. Appease clippy gods

    Jake Hartnell authored and JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    3b75780 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    ce4e4fc View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    df1591b View commit details
    Browse the repository at this point in the history
  19. Remove unused function

    JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    bfff543 View commit details
    Browse the repository at this point in the history
  20. Improve comments

    JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    360297a View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    527a600 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    b4256b1 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    2781cec View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    f96e6e4 View commit details
    Browse the repository at this point in the history
  25. Clean up types

    JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    17928bc View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    51c79c0 View commit details
    Browse the repository at this point in the history
  27. Configuration menu
    Copy the full SHA
    f20b1cb View commit details
    Browse the repository at this point in the history
  28. Configuration menu
    Copy the full SHA
    dc48b30 View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    2b04dbc View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    e48211f View commit details
    Browse the repository at this point in the history
  31. cargo fmt

    JakeHartnell committed Sep 3, 2023
    Configuration menu
    Copy the full SHA
    426d139 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    c2c230d View commit details
    Browse the repository at this point in the history

Commits on Sep 5, 2023

  1. Improve unstaking_duration validation reuse

    Jake Hartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    318cea5 View commit details
    Browse the repository at this point in the history
  2. Allowlist should apply to transfers from *or to* an address

    For example, a DAO may wish to white list a Token Staking contract (to
    allow users to stake their tokens in the DAO) or a Merkle Drop contract
    (to allow users to claim their tokens).
    JakeHartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    8c1b31f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8883b75 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    a8683f4 View commit details
    Browse the repository at this point in the history
  5. Remove commented out metadata test

    Osmosis test tube doesn't support metadata queries anymore, we assume
    metadata is set properly by the Cosmos SDK and this is well tested
    upstream.
    JakeHartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    2cb2d59 View commit details
    Browse the repository at this point in the history
  6. More informative error to address BlockBeforeSend hook executing on m…

    …inting or burning
    
    This is intended functionality. If a token is frozen, a DAO needs to
    both grant a minter allowance as well as adding the minter to the
    allowlist to allow for token transfers when the token is frozen.
    
    The new error message should make next steps clear if this edge case is
    encountered.
    JakeHartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    f2d4ac3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    5953169 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    dd93317 View commit details
    Browse the repository at this point in the history
  9. Make it possible to unset BeforeSendHook, or set to a different contract

    DAOs may wish to disable the BeforeSendHook at some point, or
    potentially set it to a custom cosmwasm contract if they wish to
    customize functionality a bit more.
    
    Modifies the SetBeforeSendHook method to allow for this, and adds tests
    that it's indeed possible to set it to nil.
    JakeHartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    7633b3e View commit details
    Browse the repository at this point in the history
  10. Default to BeforeSendHook features being disabled

    These are powerful features, but many may not want them as they can be
    abused. DAOs that want these features will have to explicitly enable
    them via a governance prop.
    JakeHartnell committed Sep 5, 2023
    Configuration menu
    Copy the full SHA
    0115fe7 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2023

  1. Configuration menu
    Copy the full SHA
    dc7af3c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    508d81c View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2023

  1. Accurate comment

    JakeHartnell committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    8c54bf2 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fa1a74a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    71137e8 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    b6f9c04 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c46597e View commit details
    Browse the repository at this point in the history
  6. Update Schema

    JakeHartnell committed Sep 9, 2023
    Configuration menu
    Copy the full SHA
    cc764d0 View commit details
    Browse the repository at this point in the history

Commits on Sep 11, 2023

  1. Fix up integration tests

    JakeHartnell committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    87aaf6d View commit details
    Browse the repository at this point in the history
  2. Remove owner from dao-voting-cw721-staked

    The concept of ownership doesn't really make sense for voting contracts.
    IMO the owner should always be the DAO.
    JakeHartnell committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    21e91ee View commit details
    Browse the repository at this point in the history
  3. Improve TF docs

    JakeHartnell committed Sep 11, 2023
    Configuration menu
    Copy the full SHA
    2d40452 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Configuration menu
    Copy the full SHA
    4778813 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c232173 View commit details
    Browse the repository at this point in the history
  3. Fix package name.

    JakeHartnell committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    be1ae92 View commit details
    Browse the repository at this point in the history
  4. Fix integration tests

    JakeHartnell committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    1c51285 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    26e24dd View commit details
    Browse the repository at this point in the history
  6. Address remaining TODOs

    JakeHartnell committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    67e8b83 View commit details
    Browse the repository at this point in the history