Skip to content

Remaining Audit Fixes & Factory Pattern #4215

Remaining Audit Fixes & Factory Pattern

Remaining Audit Fixes & Factory Pattern #4215

Triggered via pull request October 4, 2023 00:17
Status Success
Total duration 15m 44s
Artifacts

basic.yml

on: pull_request
Fit to window
Zoom out
Zoom in

Annotations

44 warnings
Lints
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Lints
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Lints
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-cw721-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-token-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lints
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lints
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lints
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Lints
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-cw721-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-token-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Lints
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-cw721-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-token-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Lints
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Lints
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions-rs/toolchain@v1, actions-rs/cargo@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test Suite
The `set-output` command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
Test Suite
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Test Suite
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-token-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-cw721-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
output filename collision.
Test Suite
output filename collision.
Test Suite
output filename collision.
Test Suite
output filename collision.
Test Suite
output filename collision.
Test Suite
output filename collision.
Test Suite
some crates are on edition 2021 which defaults to `resolver = "2"`, but virtual workspaces default to `resolver = "1"`
Test Suite
/home/runner/work/dao-contracts/dao-contracts/packages/dao-testing/Cargo.toml: dependency (token-bindings) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-cw721-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite
/home/runner/work/dao-contracts/dao-contracts/contracts/voting/dao-voting-token-staked/Cargo.toml: dependency (osmosis-std) specified without providing a local path, Git repository, version, or workspace dependency to use. This will be considered an error in future versions
Test Suite: contracts/external/cw-tokenfactory-issuer/src/msg.rs#L5
unused import: `crate::state::BeforeSendHookInfo`
Test Suite: contracts/voting/dao-voting-cw20-staked/src/msg.rs#L8
unused import: `ActiveThresholdResponse`
Test Suite
`cw-tokenfactory-issuer` (lib) generated 1 warning (run `cargo fix --lib -p cw-tokenfactory-issuer` to apply 1 suggestion)
Test Suite
`dao-voting-cw20-staked` (lib) generated 1 warning (run `cargo fix --lib -p dao-voting-cw20-staked` to apply 1 suggestion)
Test Suite: contracts/voting/dao-voting-cw721-staked/src/msg.rs#L6
unused import: `ActiveThresholdResponse`
Test Suite
`dao-voting-cw721-staked` (lib) generated 1 warning (run `cargo fix --lib -p dao-voting-cw721-staked` to apply 1 suggestion)