feat(nodeSync): fix bug that node labels is missing

D0m021ng · Jan 12, 2024 · 2b80185 · 2b80185
1 parent 5c24a54
commit 2b80185
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/pkg/job/runtime_v2/client/kube_runtime_client.go b/pkg/job/runtime_v2/client/kube_runtime_client.go
@@ -358,10 +358,6 @@ func (n *NodeHandler) addQueue(node *corev1.Node, action pfschema.ActionType, la
 			capacity[resourceName] = rValue.String()
 		}
 	}
-	if labels == nil {
-		labels = make(map[string]string)
-	}
-	labels[pfschema.PFNodeCardTypeAnno] = n.getNodeCardType(node)
 	nodeSync := &api.NodeSyncInfo{
 		Name:     node.Name,
 		Status:   getNodeStatus(node),
@@ -389,6 +385,8 @@ func (n *NodeHandler) UpdateNode(old, new interface{}) {
 
 	oldLabels := getLabels(n.labelKeys, oldNode.Labels)
 	newLabels := getLabels(n.labelKeys, newNode.Labels)
+	oldLabels[pfschema.PFNodeCardTypeAnno] = n.getNodeCardType(oldNode)
+	newLabels[pfschema.PFNodeCardTypeAnno] = n.getNodeCardType(newNode)
 
 	if oldStatus == newStatus &&
 		reflect.DeepEqual(oldNode.Status.Allocatable, newNode.Status.Allocatable) &&