Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): Update factory reset condition to ignore write attempt #451

Merged
merged 2 commits into from
Dec 27, 2023
Merged

fix(core): Update factory reset condition to ignore write attempt #451

merged 2 commits into from
Dec 27, 2023

Conversation

amanCypherock
Copy link
Contributor

No description provided.

@amanCypherock amanCypherock added the bugfix This change fix something that's not working as expected label Dec 27, 2023
@amanCypherock amanCypherock self-assigned this Dec 27, 2023
@rohanagarwal94
Copy link

Task linked: PRF-6203 Update create wallet and delete wallet flows to resolve apdu len error

ujjwal-cyph
ujjwal-cyph approved these changes Dec 27, 2023
View reviewed changes
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjwal-cyph ujjwal-cyph merged commit be0afc5 into feat/save-wallet-nonce-on-creation/PRF-6203 Dec 27, 2023
13 checks passed
@ujjwal-cyph ujjwal-cyph deleted the fix/factory-reset-condiiton-updated branch December 27, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal-cyph ujjwal-cyph ujjwal-cyph approved these changes

Assignees

@amanCypherock amanCypherock

Labels
bugfix This change fix something that's not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanCypherock @rohanagarwal94 @ujjwal-cyph