-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verify wallet before delete #446
Merged
ujjwal-cyph
merged 5 commits into
feat/save-wallet-nonce-on-creation/PRF-6203
from
feat/verify-before-delete/PRF-6558
Dec 20, 2023
Merged
Verify wallet before delete #446
ujjwal-cyph
merged 5 commits into
feat/save-wallet-nonce-on-creation/PRF-6203
from
feat/verify-before-delete/PRF-6558
Dec 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Task linked: PRF-6557 Verify wallet nonce on fetching a wallet |
Task linked: PRF-6558 Verify wallet before deleting |
amanCypherock
force-pushed
the
feat/verify-before-delete/PRF-6558
branch
2 times, most recently
from
December 11, 2023 07:08
b9744f4
to
399a98f
Compare
amanCypherock
changed the title
feat(core): Record card write attempt
Verify wallet before delete
Dec 16, 2023
amanCypherock
force-pushed
the
feat/verify-fetched-wallet/PRF-6557
branch
from
December 16, 2023 09:54
8a24fb1
to
aec0477
Compare
amanCypherock
force-pushed
the
feat/verify-before-delete/PRF-6558
branch
from
December 16, 2023 09:59
399a98f
to
e7d4b6d
Compare
ujjwal-cyph
reviewed
Dec 16, 2023
ujjwal-cyph
requested changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix minor comments
amanCypherock
force-pushed
the
feat/verify-fetched-wallet/PRF-6557
branch
from
December 19, 2023 08:42
aec0477
to
5b422c9
Compare
amanCypherock
force-pushed
the
feat/verify-before-delete/PRF-6558
branch
from
December 20, 2023 06:46
e7d4b6d
to
936d5cf
Compare
amanCypherock
force-pushed
the
feat/verify-fetched-wallet/PRF-6557
branch
from
December 20, 2023 06:49
5b422c9
to
0efecdc
Compare
amanCypherock
force-pushed
the
feat/verify-before-delete/PRF-6558
branch
from
December 20, 2023 06:50
936d5cf
to
fd11071
Compare
amanCypherock
force-pushed
the
feat/verify-before-delete/PRF-6558
branch
from
December 20, 2023 08:27
ae6d894
to
ea971c0
Compare
Base automatically changed from
feat/verify-fetched-wallet/PRF-6557
to
feat/save-wallet-nonce-on-creation/PRF-6203
December 20, 2023 08:28
ujjwal-cyph
approved these changes
Dec 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ujjwal-cyph
merged commit Dec 20, 2023
1d6e70c
into
feat/save-wallet-nonce-on-creation/PRF-6203
13 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates the change where a wallet is verified before it is deleted.
These are the changes incorporated