Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify wallet before delete #446

Conversation

amanCypherock
Copy link
Contributor

@amanCypherock amanCypherock commented Dec 6, 2023

This PR incorporates the change where a wallet is verified before it is deleted.

These are the changes incorporated

  • Record card write attempt on flash
  • Fetch share (and compare with wallet intended for deletion) from the card before deleting the wallet
  • Updated factory reset to include all wallets with share present on device during verification from 2 cards.

@amanCypherock amanCypherock added the enhancement Improvements to an existing feature label Dec 6, 2023
@amanCypherock amanCypherock self-assigned this Dec 6, 2023
@rohanagarwal94
Copy link

@rohanagarwal94
Copy link

Task linked: PRF-6558 Verify wallet before deleting

@amanCypherock amanCypherock force-pushed the feat/verify-before-delete/PRF-6558 branch 2 times, most recently from b9744f4 to 399a98f Compare December 11, 2023 07:08
@amanCypherock amanCypherock changed the title feat(core): Record card write attempt Verify wallet before delete Dec 16, 2023
@amanCypherock amanCypherock force-pushed the feat/verify-fetched-wallet/PRF-6557 branch from 8a24fb1 to aec0477 Compare December 16, 2023 09:54
@amanCypherock amanCypherock force-pushed the feat/verify-before-delete/PRF-6558 branch from 399a98f to e7d4b6d Compare December 16, 2023 09:59
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix minor comments

common/interfaces/flash_interface/flash_api.c Outdated Show resolved Hide resolved
@amanCypherock amanCypherock force-pushed the feat/verify-fetched-wallet/PRF-6557 branch from aec0477 to 5b422c9 Compare December 19, 2023 08:42
@amanCypherock amanCypherock force-pushed the feat/verify-before-delete/PRF-6558 branch from e7d4b6d to 936d5cf Compare December 20, 2023 06:46
@amanCypherock amanCypherock force-pushed the feat/verify-fetched-wallet/PRF-6557 branch from 5b422c9 to 0efecdc Compare December 20, 2023 06:49
@amanCypherock amanCypherock force-pushed the feat/verify-before-delete/PRF-6558 branch from 936d5cf to fd11071 Compare December 20, 2023 06:50
@amanCypherock amanCypherock force-pushed the feat/verify-before-delete/PRF-6558 branch from ae6d894 to ea971c0 Compare December 20, 2023 08:27
Base automatically changed from feat/verify-fetched-wallet/PRF-6557 to feat/save-wallet-nonce-on-creation/PRF-6203 December 20, 2023 08:28
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ujjwal-cyph ujjwal-cyph merged commit 1d6e70c into feat/save-wallet-nonce-on-creation/PRF-6203 Dec 20, 2023
13 checks passed
@ujjwal-cyph ujjwal-cyph deleted the feat/verify-before-delete/PRF-6558 branch December 20, 2023 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants