Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(nfc): Error text updated for already tapped card #420

Merged
merged 2 commits into from
Oct 20, 2023
Merged

fix(nfc): Error text updated for already tapped card #420

merged 2 commits into from
Oct 20, 2023

Conversation

amanCypherock
Copy link
Contributor

@amanCypherock amanCypherock added the bugfix This change fix something that's not working as expected label Oct 10, 2023
@amanCypherock amanCypherock self-assigned this Oct 10, 2023
@rohanagarwal94
Copy link

Task linked: PRF-6190 On device if same card is tapped in clear data flow then device says "wrong card sequence"

ujjwal-cyph
ujjwal-cyph reviewed Oct 18, 2023
View reviewed changes
src/constant_texts.c Outdated Show resolved Hide resolved
ujjwal-cyph
ujjwal-cyph requested changes Oct 18, 2023
View reviewed changes
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finalize the message and update accordingly

@amanCypherock amanCypherock force-pushed the fix/text-already-tapped-card branch from 34b4757 to 31dbbe8 Compare October 19, 2023 05:41
@amanCypherock amanCypherock merged commit db23e8f into refactor/core-framework Oct 20, 2023
@amanCypherock amanCypherock deleted the fix/text-already-tapped-card branch October 20, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ujjwal-cyph ujjwal-cyph ujjwal-cyph approved these changes

Assignees

@amanCypherock amanCypherock

Labels
bugfix This change fix something that's not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@amanCypherock @rohanagarwal94 @ujjwal-cyph