Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove dead code #412

Merged
merged 6 commits into from
Dec 16, 2023
Merged

chore: Remove dead code #412

merged 6 commits into from
Dec 16, 2023

Conversation

ujjwal-cyph
Copy link
Collaborator

@ujjwal-cyph ujjwal-cyph commented Sep 22, 2023 •
edited
Loading

  • Remove dead code
  • Remove test vectors for EVM xpub & BTC testnet (their support is removed)

@ujjwal-cyph ujjwal-cyph self-assigned this Sep 22, 2023
@ujjwal-cyph ujjwal-cyph force-pushed the refactor/evm-transaction-meta branch from 415b9a1 to 83a44e8 Compare September 22, 2023 08:40
Base automatically changed from refactor/evm-transaction-meta to refactor/core-framework September 29, 2023 09:59
@ujjwal-cyph ujjwal-cyph marked this pull request as ready for review November 23, 2023 13:14
amanCypherock
amanCypherock reviewed Dec 15, 2023
View reviewed changes
Copy link
Contributor

@amanCypherock amanCypherock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the function byte_array_to_txn_metadata ?

amanCypherock
amanCypherock suggested changes Dec 15, 2023
View reviewed changes
Copy link
Contributor

@amanCypherock amanCypherock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need the function byte_array_to_txn_metadata ?

@ujjwal-cyph
Copy link
Collaborator Author

Do we need the function byte_array_to_txn_metadata ?

No. Removed it.

@ujjwal-cyph ujjwal-cyph merged commit 4a9dbbb into refactor/core-framework Dec 16, 2023
13 checks passed
@ujjwal-cyph ujjwal-cyph deleted the source-clean-up branch December 16, 2023 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amanCypherock amanCypherock amanCypherock approved these changes

Assignees

@ujjwal-cyph ujjwal-cyph

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ujjwal-cyph @amanCypherock @Ujjwal0501