Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Base to support EVMs #113

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

hiporox
Copy link

@hiporox hiporox commented Jun 16, 2024

Currently the Cypherrock does not support the Base Chain. As this chain is gaining popularity, I decided it would be good to add it to the list of support EVM compatible chains

Copy link

changeset-bot bot commented Jun 16, 2024

⚠️ No Changeset found

Latest commit: 0e64ac8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@hiporox hiporox changed the title [FEATURE] Add Base to support EVMs feat: Add Base to support EVMs Jun 16, 2024
Update appId for Base to reflect the firmware app ID instead of the chain id
@hiporox
Copy link
Author

hiporox commented Jun 16, 2024

SDK support for the firmware change proposed in Cypherock/x1_wallet_firmware#515

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant