Fix query parameters of externalMedia #133
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -264,8 +264,8 @@ type ExternalMediaOptions struct { | |||
| // Direction specifies the directionality of the audio stream. Options include 'both'. This parameter is optional and if not specified, 'both' will be used. | |||
| Direction string `json:"direction"` | |||
|
|
|||
| // Variables defines the set of channel variables which should be bound to this channel upon creation. This parameter is optional. | |||
| Variables map[string]string `json:"variables"` | |||
There was a problem hiding this comment.
Is there any need to remove Variables from ExternalMediaOptions struct and pass them as argument ?
Also data field was introduced with Asterisk 18, there is no such field in Asterisk 16 and its EOL is 2023-10-09.
I propose to ignore data field for now leaving struct as it is and only fix handling of ExternalMediaOptions for query.
|
hey guys! It is unknown when the PR will be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer #118
Previous
ExternalMediaimplementation uses wholeExternalMediaOptionsas a request body.But asterisk only uses
Variablesfield as the request body. So Asterisk 18(LTS) responds as400 Bad Requestwhich demand mandatory query parameters.This patch uses
ExternalMediaOptionsas query parameters except aVariableswhich is a JSON format.This fix is just only for the
externalMediaAPI.Go ARI uses similar approach in
channelAPI(e.g. originate) like theexternalMediaAPI that doesn't use query parameters.This change is