Skip to content

Commit

Permalink
Add missing actions to validation. Closes #1059.
Browse files Browse the repository at this point in the history
  • Loading branch information
jshcodes committed Oct 30, 2023
1 parent 7fad6c1 commit 0808098
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
5 changes: 4 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,12 @@
+ Fixed: Error when trying to directly import falconpy module (no package installation). Closes #1056.
- `_auth_object/_falcon_interface.py`
- `_util/_functions.py`
- Thanks to @tsullivan06 for identifying and reporting this issue. 🙇
- Thanks go out to @tsullivan06 for identifying and reporting this issue. 🙇
+ Fixed: Legacy Uber Class is not logging Operation ID in debug logs. Closes #1057.
- `api_complete/_legacy.py`
+ Fixed: Can not use `add-rule-group` and `remove-rule-group` actions with the __`performFirewallPoliciesAction`__ operation. Closes #1059.
- `firewall_policies.py`
- Thanks go out to @api-clobberer for identifying and reporting this issue. 🙇

---

Expand Down
4 changes: 3 additions & 1 deletion src/falconpy/firewall_policies.py
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,9 @@ def perform_action(self: object, body: dict = None, parameters: dict = None, **k
Swagger URL
https://assets.falcon.crowdstrike.com/support/api/swagger.html#/firewall-policies/performFirewallPoliciesAction
"""
_allowed_actions = ['add-host-group', 'disable', 'enable', 'remove-host-group']
_allowed_actions = ['add-host-group', 'disable', 'enable',
'remove-host-group', 'add-rule-group', 'remove-rule-group'
]
operation_id = "performFirewallPoliciesAction"
parameter_payload = args_to_params(parameters, kwargs, Endpoints, operation_id)
action_name = parameter_payload.get("action_name", "Not Specified")
Expand Down

0 comments on commit 0808098

Please sign in to comment.