Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use volta for pnpm version #184

Open
NullVoxPopuli opened this issue May 16, 2023 · 1 comment
Open

use volta for pnpm version #184

NullVoxPopuli opened this issue May 16, 2023 · 1 comment

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented May 16, 2023

I noticed in some upgrade prs, there were some instability in the lockfile.

I think that's been fixed in later versions of pnpm.

Using the same version across all machine can happen with:

This setting in the repo: https://github.com/NullVoxPopuli/limber/blob/main/package.json#L23
This ci abstraction: https://github.com/NullVoxPopuli/limber/blob/main/.github/workflows/ci.yml#L45 (or the wyvox one, which includes checkout)
And this env var on each person's machine: https://github.com/NullVoxPopuli/dotfiles/blob/main/home/scripts/bash-support/environment-augmentations.sh#L59
(Hopefully temporary until volta finalizes pnpm support)

@vitch
Copy link
Contributor

vitch commented May 17, 2023

until volta finalizes pnpm support

Adding a link to volta-cli/volta#737 for reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants