Device service refactoring integration #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
April 26, 2023 09:19
Refactor abstract classes and auth service in such a way that they can be moved to common.
- Change API folder structure (WIP) - Create test folder structure - Move callback routes to operations - Move websocket routes into device operations - Make small changes to API (e.g. required type on device creation)
- Change structure of test data folder - Fix small issue in auth service (test suite name)
- Add possibility to remove suites - WIP: Change input to write function to Partial because it caused problems with type inference
- Start writing repository test suites - Add Init and Update Device Types - Add example device data for tests
- add new route to update connection state of devices - make url, type and name required on a device - add new init and update types for devices - update connection state definition - add connection-state-changed message - apply changes and implement new route (WIP)
- make property devices required on device groups
- make properties connected, announcedAvailability, availability-
Rules and services required on ConcreteDeviceModel
- adapt device repository to reflect changes to models and api
- add test for POST /devices/{device_id} (WIP)
jonau
requested changes
Apr 28, 2023
- reset settings.json to original state - edit function in soa client for better readability
jonau
approved these changes
Apr 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.