Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: feat(components/tree): reusable recursive tree components #777

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

BradenM
Copy link
Member

@BradenM BradenM commented Mar 5, 2024

Description

WIP:

  • feat(pages/admin/rag): add search to rag files
  • feat(components/tree): add generic node/tree interfaces, abstract classes
  • feat(components/tree): add concrete impl for filesystem nodes
  • feat(components/tree): wip render tree tsx component

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

@BradenM BradenM changed the title WIP; feat(components/tree): reusable recursive tree components WIP: feat(components/tree): reusable recursive tree components Mar 5, 2024
@BradenM BradenM marked this pull request as draft March 5, 2024 08:31
@BradenM BradenM force-pushed the feat/tree-components branch from 5b37b79 to 8245da3 Compare March 5, 2024 08:32
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 153 lines in your changes are missing coverage. Please review.

Project coverage is 15.77%. Comparing base (f19cb37) to head (2cc3214).

Files Patch % Lines
src/components/tree/node.ts 0.00% 69 Missing ⚠️
src/components/tree/Recurse.tsx 0.00% 48 Missing ⚠️
src/components/tree/filesystem.ts 0.00% 36 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
- Coverage   15.80%   15.77%   -0.04%     
==========================================
  Files         364      367       +3     
  Lines       77379    77532     +153     
  Branches      814      817       +3     
==========================================
  Hits        12233    12233              
- Misses      65146    65299     +153     
Flag Coverage Δ
unitTests 15.77% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BradenM BradenM force-pushed the feat/tree-components branch from 8245da3 to 2cc3214 Compare March 5, 2024 08:33
Copy link

github-actions bot commented Mar 5, 2024

Playwright test results

passed  23 passed
flaky  3 flaky

Details

stats  26 tests across 12 suites
duration  5 minutes, 33 seconds
commit  2cc3214

Flaky tests

firefox-setup → auth.setup.ts → authenticate as admin - ( @primary @slow @read @development @staging @production )
firefox-setup → auth.setup.ts → authenticate as user - ( @primary @slow @read @development @staging @production )
chromium-setup → auth.setup.ts → authenticate as admin - ( @primary @slow @read @development @staging @production )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant