Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/printInterception #1265

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix/printInterception #1265

wants to merge 2 commits into from

Conversation

DatGamingStache
Copy link
Contributor

  • fix: intercepted print command for worksite printing
  • fix: handled if no worksite is selected when ctrl+p

Description

Current Behavior

New Behavior

Screenshots

Related Issue

Pull Request Type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation changes

Checklist

  • My code follows the code style of this project.
  • I have updated the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Does this introduce a breaking change?

  • Yes
  • No

Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 17.82%. Comparing base (4521073) to head (73cf1e5).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
src/pages/Work.vue 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1265      +/-   ##
==========================================
- Coverage   17.83%   17.82%   -0.01%     
==========================================
  Files         417      417              
  Lines       64395    64413      +18     
  Branches     1366     1366              
==========================================
  Hits        11482    11482              
- Misses      52913    52931      +18     
Flag Coverage Δ
unitTests 17.82% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

Playwright test results

passed  48 passed
flaky  2 flaky

Details

stats  50 tests across 11 suites
duration  3 minutes, 36 seconds
commit  73cf1e5

Flaky tests

chromium › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )
firefox › pages/user-profile.test.ts › UserProfile › should have visible data-testids - ( @primary @slow @read @development @staging @production )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant