Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change minimum timeout to 0.5 seconds #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ewalke31
Copy link

@ewalke31 ewalke31 commented Apr 2, 2019

The loop call_later() function returns a timeout message for times >= 1 second, so changing the minimum timeout to 0.5 allows this to be avoided.

The loop call_later() function returns a timeout message for times >= 1 second, so changing the minimum timeout to 0.5 allows this to be avoided.
@sethnielson
Copy link
Contributor

call_later can be used with decimal timeout.

@lol-fi
Copy link
Contributor

lol-fi commented Apr 3, 2019

call_later can be used with decimal timeout.

So what are you saying...????? It messes up the timeout is greater than 1 second so we want it to have a decimal timeout........but right now we aren't allowed to go less than five seconds....which is more than one second

Copy link
Contributor

@lol-fi lol-fi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great request

Copy link

@vaikunthsd vaikunthsd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Please resolve the conflicts before merging the changes into main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants