Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reverse registrar #3

Merged
merged 10 commits into from
Nov 5, 2024
Merged

Reverse registrar #3

merged 10 commits into from
Nov 5, 2024

Conversation

overcat
Copy link
Contributor

@overcat overcat commented Nov 4, 2024

No description provided.

@earrietadev
Copy link
Contributor

@overcat everything seems good, I only left a few comments. I really like the idea of using None as a way to tell the contract we want to delete a field, I will do the same in the next update for the other contracts, that will remove one method and will make the contract WASM smaller

@overcat overcat marked this pull request as ready for review November 5, 2024 12:36
@overcat overcat requested a review from earrietadev November 5, 2024 12:40
@earrietadev earrietadev merged commit a56e634 into Creit-Tech:main Nov 5, 2024
1 check passed
@overcat overcat mentioned this pull request Nov 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tupui tupui tupui left review comments

@earrietadev earrietadev Awaiting requested review from earrietadev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@overcat @earrietadev @tupui