gflags: new package #107
Merged
gflags: new package #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ham22
requested changes
Nov 25, 2016
| PKG_LICENSE:=BSD-3c | ||
| PKG_LICENSE_FILE:=COPYING.txt | ||
|
|
||
| PKG_BUILD_DIR:=$(BUILD_DIR)/$(PKG_NAME)-$(PKG_VERSION) |
| DEPENDS:=+libstdcpp | ||
| TITLE:=gflags | ||
| endef | ||
| define Package/gflags/description |
| define Package/gflags/install | ||
| $(INSTALL_DIR) $(1)/usr/lib/ | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/* $(1)/usr/lib/ | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/* $(STAGING_DIR)/usr/lib/ |
There was a problem hiding this comment.
Installing to staging should be done in the Build/InstallDev target
| $(INSTALL_DIR) $(1)/usr/include/ | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/include/* $(STAGING_DIR)/usr/include/ | ||
| endef | ||
| $(eval $(call BuildPackage,$(PKG_NAME))) |
There was a problem hiding this comment.
If your going to use the variable instead of the name then please do this consistently for all referemces to gflags
abhilashtuse
force-pushed
the
gflags-feeds
branch
from
6950c98 to
3a120af
Compare
ghost
reviewed
Nov 28, 2016
| PKG_VERSION:=v2.1.2 | ||
| PKG_RELEASE:=1 | ||
|
|
||
| PKG_SOURCE_PROTO:=git |
There was a problem hiding this comment.
I could not compile because PKG_SOURCE_VERSION and PKG_SOURCE_SUBDIR are missing.
I suggest:
PKG_VERSION:=2.1.2
...
PKG_SOURCE_VERSION=v$(PKG_VERSION)
PKG_SOURCE_SUBDIR:=$(PKG_NAME)-$(PKG_VERSION)
ghost
reviewed
Nov 28, 2016
| PKG_NAME:=gflags | ||
| PKG_VERSION:=v2.1.2 | ||
| PKG_RELEASE:=1 | ||
|
|
There was a problem hiding this comment.
You could also set PKG_LICENSE and PKG_LICENSE_FILE.
ghost
reviewed
Nov 28, 2016
| define Package/$(PKG_NAME)/install | ||
| $(INSTALL_DIR) $(1)/usr/lib/ | ||
| $(CP) $(PKG_INSTALL_DIR)/usr/lib/* $(1)/usr/lib/ | ||
| $(INSTALL_DIR) $(1)/usr/include/ |
There was a problem hiding this comment.
You also need to copy the include otherwise it is not part of the ipk.
There was a problem hiding this comment.
You mean copy to staging dir right?
That's done in Build/InstallDev below?
abhilashtuse
force-pushed
the
gflags-feeds
branch
from
3a120af to
12b35bf
Compare
nikhil-zinjurde-imgtec
suggested changes
Nov 29, 2016
abhilashtuse
force-pushed
the
gflags-feeds
branch
2 times, most recently
from
6186fc8 to
bb47bd2
Compare
added 2 commits
November 29, 2016 16:26
Signed-off-by: Abhilash Tuse <[email protected]>
Fixes dependency check error when building applications which uses gflags. Signed-off-by: Abhilash Tuse <[email protected]>
abhilashtuse
force-pushed
the
gflags-feeds
branch
from
bb47bd2 to
9eef923
Compare
ghost
approved these changes
Nov 29, 2016
nikhil-zinjurde-imgtec
approved these changes
Nov 29, 2016
Ham22
approved these changes
Nov 29, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This connects to CreatorDev/openwrt#112