Convert Blade*Connection* classes to context managed classes #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Convert BladeConnection, BladeConnectionSet, BladeSSHConnection and BladeSSHConnectionSet classes into context managed classes -- add enter() and exit() methods -- so that the provider level operations that return them can be used inside or outside of a 'with' clause. This will allow the Cluster layer to implement node context managed classes of its own that use these connections and connection sets as underlying mechanisms. Without this, it was not possible to properly separate functionality between the API layers.
This is a backward compatible change.