Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAYSAT-1941: add validation to check for existence of rootfs_provider #291

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

ethanholen-hpe
Copy link
Contributor

@ethanholen-hpe ethanholen-hpe commented Nov 25, 2024

Summary and Scope

Add validation to check for existence of rootfs_provider and rootfs_provider_passthrough before checking for empty string.

Issues and Related PRs

Testing

Tested on:

  • Local development environment

Test description:

Tests added to verify functionality

Risks and Mitigations

None

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable
  • HPC Product Announcement prepared, if applicable

@ethanholen-hpe ethanholen-hpe marked this pull request as ready for review November 25, 2024 17:31
@ethanholen-hpe ethanholen-hpe merged commit cd20601 into main Nov 25, 2024
3 checks passed
@ethanholen-hpe ethanholen-hpe deleted the CRAYSAT-1941 branch November 25, 2024 17:33
@ethanholen-hpe
Copy link
Contributor Author

/backport release/3.32

Copy link

Backporting into branch release/3.32 was successful. New PR: #292

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants