CRAYSAT-1916: Fix unused code in get_config_value for handling infinite BOS timeouts
#277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haasken-hpe
approved these changes
Oct 18, 2024
annapoorna-s-alt
force-pushed
the
CRAYSAT-1916-bos
branch
from
753a7c8
to
44a14eb
Compare
|
Testing output on fanta: https://gist.github.com/annapoorna-s-alt/7e428300b9cc269dcb8a42f52cf2c333 |
shivaprasad-metimath
approved these changes
Oct 21, 2024
haasken-hpe
approved these changes
Oct 21, 2024
This was referenced Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary and Scope
Fix unused code in
get_config_valuefor handling infinite BOS timeoutsIssues and Related PRs
Resolves CRAYSAT-1913.
Testing
List the environments in which these changes were tested.
Tested on:
Fanta
Test description:
Test the changes with shutdown/boot/reboot with bos-operations
Risks and Mitigations
Minimal
Pull Request Checklist