Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CASMTRIAGE-7079: Paradise: Fixed functional hardware test to pass processor types of "FPGA" #155

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

jwlv
Copy link
Contributor

@jwlv jwlv commented Jun 17, 2024

Summary and Scope

Hardare tavern test was failing when run against Paradise. Paradise includes a new processor type "FPGA" that was not expected by the test. The change here is to add "FPGA" as a valid processor type. This was not hit previously because the tavern tests do not test against each node type on a system. Node selection is random, and we got unlucky that no Paradise node had been previously chosen.

Issues and Related PRs

Testing

Tested on:

  • tyr

Test description:

Made a temporary change to the test_hardware.tavern.yaml file:

- url: "{hsm_base_url}/hsm/v2/State/Components?type=Node"
+ url: "{hsm_base_url}/hsm/v2/State/Components?type=Node&id=x3000c0s33b2n0"

This ensured the test was run against a Paradise node. The test then passed. I removed this code change before making the final PR.

  • Were the install/upgrade-based validation checks/tests run (goss tests/install-validation doc)? Y
  • Were continuous integration tests run? Y
  • Was upgrade tested? Y
  • Was downgrade tested? Y

Pull Request Checklist

  • Version number(s) incremented, if applicable
  • Copyrights updated
  • License file intact
  • Target branch correct
  • CHANGELOG.md updated
  • Testing is appropriate and complete, if applicable

@jwlv jwlv requested review from a team as code owners June 17, 2024 17:18
Copy link

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd:2.26.0-20240617171838.0ec4842

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd:2.26.0-20240617171838.0ec4842

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd:2.26.0-20240617171838.0ec4842

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd:2.26.0-20240617171838.0ec4842 > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of ea710b3 and the PR base branch. Good luck and make rocket go now! 🌮 🚀

Copy link

👋 Hey! Here is the image we built for you (Artifactory Link):

artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.26.0-20240617171843.0ec4842

Use podman or docker to pull it down and inspect locally:

podman pull artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.26.0-20240617171843.0ec4842

Or, use this script to pull the image from the build server to a dev system:

Dev System Pull Script

Note the following script only applies to systems running CSM 1.2 or later.

#!/usr/bin/env bash

IMAGE=artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.26.0-20240617171843.0ec4842

podman run --rm --network host  \
    quay.io/skopeo/stable copy \
    --src-tls-verify=false \
    --dest-tls-verify=false \
    --dest-username "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.username | @base64d')" \
    --dest-password "$(kubectl -n nexus get secret nexus-admin-credential -o json | jq -r '.data.password | @base64d')" \
    docker://$IMAGE \
    docker://registry.local/$IMAGE
Snyk Report

Coming soon

Software Bill of Materials
cosign download sbom artifactory.algol60.net/csm-docker/unstable/cray-smd-hmth-test:2.26.0-20240617171843.0ec4842 > container_image.spdx

If you don't have cosign, then you can get it here.

Note: this SHA is the merge of ea710b3 and the PR base branch. Good luck and make rocket go now! 🌮 🚀

@jwlv jwlv requested review from rfrost-hpe and mtupitsyn June 17, 2024 17:30
@jwlv jwlv merged commit 970d121 into master Jun 17, 2024
15 checks passed
@jwlv jwlv deleted the CASMTRIAGE-7079.1.6 branch June 17, 2024 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants