CASMNET-2183 RVR NMN Support

[lukebates123]

Summary and Scope

Previously all air cooled nodes, both managed (e.g. UAN) and management (managers, workers and storage nodes) existed on the same VLAN. The data structures existed from the beginning in SLS to separate managed and management node traffic, but structurally this was never done. This change allows managed nodes to be moved to separate networks (VLAN and subnets as prescribed in SLS). This change also limits access of the managed nodes to the management plane NMN.

• Add Support for River NMN via CLI flag
• Allows the user to select what nodes are put onto the RVR-NMN VLAN based on the custom_config.yaml input file.
• No IP-helper configured on L3 SVIs by default
  • This can be set within the river_nmn parameter in the custom_config.yaml file. dhcp: true will set the ip-helper of the river_nmn network to the default dhcp server (kea).
• ACLs only allow communcation to the nmn-metallb network
• The default behavior of how configs are generated and what network they go on does not change
• Add black_hole_vlan_1 and black_hole_vlan_2 to variables in custom_config.yaml
• Fix Aruba Edge switch templates

• I have added new tests to cover the new code
• If adding a new file, I have updated pyinstaller.py
• I have added entries in CHANGELOG.md for the changes in this PR

Issues and Related PRs

CASMNET-2183

Testing

Generated configs for a Customer system with storage nodes
custom_config.yaml snippet

river_nmn:
  nodes:
    - storage1-25
    - storage10-11
    - cn926
    - cn954
  dhcp: false
black_hole_vlan
black_hole_vlan_1: 4000
black_hole_vlan_2: 4001

sw-leaf-bmc-004.txt

sw-leaf-001.txt
sw-leaf-002.txt

sw-spine-001.txt
sw-spine-002.txt

snippet shows that only nodes selected via the config generation are moved to the RVR VLAN.

interface 1/1/1
    no shutdown
    mtu 9198
    description storage001:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2800
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/2
    no shutdown
    mtu 9198
    description storage002:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2800
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/3
    no shutdown
    mtu 9198
    description storage003:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2800
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/4
    no shutdown
    mtu 9198
    description storage004:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2800
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/5
    no shutdown
    mtu 9198
    description storage005:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/6
    no shutdown
    mtu 9198
    description storage006:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2800
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge
interface 1/1/7
    no shutdown
    mtu 9198
    description storage007:ocp:2<==sw-leaf-bmc-004
    no routing
    vlan access 2
    spanning-tree bpdu-guard
    spanning-tree port-type admin-edge

[trad511]

Make sure the text of the PR is up to date. Still references the flag behavior rather than custom-config

[rustydb]

Rebased on #521 and all earlier changes.