GH-724 Fix copy-n-paste between two orchestrations #810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #724
This change allows the copy-n-paste of nodes that call script functions, emit script signals, or get or set script variable values. The granular behavior for each node type is as follows:
Emit Script Signal Node
Get/Set Variable Node
Call Script Function
The goals of this change were primarily to avoid the crash that users were previously experiencing, but to also make the copy and paste across Orchestrations much easier. For script functions, it's expected that users would create the function first in the target orchestration before pasting any nodes that call such function. This also means that the contents of the script function itself isn't automatically copied & pasted when copying a "call script function" node.
In addition to the above, when selecting nodes and pressing the
ui_copy
(Ctrl+C
) operation, if a node cannot be duplicated such as event nodes, rather than printing a message to the Output Panel, users will be presented a dialog window instead and the clipboard will not be populated. Users will need to unselect such nodes and re-execute the copy operation.