fix error in volume-filling factor

* should be working now
CraigYanitski · Jul 30, 2024 · d1c2ecb · d1c2ecb
1 parent 5404504
commit d1c2ecb
Showing 1 changed file with 16 additions and 6 deletions.
diff --git a/kosmatau3d/models/voxel.py b/kosmatau3d/models/voxel.py
@@ -513,13 +513,23 @@ def set_properties(
                 / 100**3
                 for ens in range(len(constants.clump_mass_number))
             ]
-        self.__volume_factor = volume_factor
-        if isinstance(ensemble_density, (list, tuple, np.ndarray)):
-            self.__ensemble_density = ensemble_density
         else:
-            self.__ensemble_density = [ensemble_density] * len(
-                constants.clump_mass_number
-            )
+            if isinstance(ensemble_density, (list, tuple, np.ndarray)):
+                self.__ensemble_density = ensemble_density
+            else:
+                self.__ensemble_density = [ensemble_density] * len(
+                    constants.clump_mass_number
+                )
+            self.__volume_factor = [
+                self.__ensemble_mass[ens]
+                * constants.mass_solar
+                / self.__ensemble_density[ens]
+                / constants.mass_h
+                / constants.voxel_size**3
+                / constants.pc**3
+                / 100**3
+                for ens in range(len(constants.clump_mass_number))
+            ]
 
         if isinstance(fuv, (list, tuple, np.ndarray)):
             self.__fuv = fuv