Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Add Alpha Color support to DrawFilledRectangle #3094

Closed
wants to merge 1 commit into from
Closed

🎨 Add Alpha Color support to DrawFilledRectangle #3094

wants to merge 1 commit into from

Conversation

cosmicdaman
Copy link

So I made a discovery that If you use DrawPoint for DrawFilledRectangle, it enables you to use a System.Drawing.Color with an alpha value less than 255. Thought I might share it.

9xbt
9xbt suggested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@9xbt 9xbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the love of god, make DrawLine support colors with the alpha channel instead of using DrawPoint

MishaProductions
MishaProductions requested changes Oct 25, 2024
View reviewed changes
Copy link
Member

@MishaProductions MishaProductions left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes will probably make the function significantly slower.

@TheVogels
Copy link

These changes will probably make the function significantly slower.

I think it should mix colors if alpha != byte.MaxValue and don't draw if alpha == byte.MinValue.

@cosmicdaman
Copy link
Author

cosmicdaman commented Nov 1, 2024 •
edited
Loading

For the love of god, make DrawLine support colors with the alpha channel instead of using DrawPoint

working on it

@cosmicdaman
Copy link
Author

this may sound dumb but i give up lol
cosmos just won't give me any more FPS

@cosmicdaman cosmicdaman closed this Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@9xbt 9xbt 9xbt requested changes

@MishaProductions MishaProductions MishaProductions requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cosmicdaman @TheVogels @MishaProductions @9xbt