Merge pull request #46 from mwilbz/text-parser-tests

Add unit tests for TextParser
CornellNLP · Jun 2, 2020 · 26f754a · 26f754a
2 parents 987b703 + 0fb534f
commit 26f754a
Show file tree

Hide file tree

Showing 17 changed files with 603 additions and 4 deletions.
diff --git a/.github/workflows/continuous-integration.yml b/.github/workflows/continuous-integration.yml
@@ -23,4 +23,4 @@ jobs:
         python -m pip install .
     - name: Run tests
       run: |
-        cd tests && python run_all_tests.py
+        python convokit/tests/run_all_tests.py
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
@@ -61,7 +61,7 @@ Please ensure that your contributions adhere to the existing coding style used t
 Please ensure that all contributions have been tested for integration with existing ConvoKit code. This is particularly pertinent for contributions that make changes to existing functions or modules. Unit tests will run automatically on Github when a pull request is opened, and may be run locally with
 
 ```
-cd tests/ && python run_all_tests.py
+cd convokit/tests/ && python run_all_tests.py
 ```
 
 after installing `pip install -r requirements.txt` and `pip install .` from the project directory.

diff --git a/convokit/tests/__init__.py b/convokit/tests/__init__.py
diff --git a/...otebook_testers/add_utterances_test.ipynb → ...otebook_testers/add_utterances_test.ipynb b/...otebook_testers/add_utterances_test.ipynb → ...otebook_testers/add_utterances_test.ipynb
diff --git a/...k_testers/convokitIndex_issues_demo.ipynb → ...k_testers/convokitIndex_issues_demo.ipynb b/...k_testers/convokitIndex_issues_demo.ipynb → ...k_testers/convokitIndex_issues_demo.ipynb
diff --git a/...sters/reindex_conversations_example.ipynb → ...sters/reindex_conversations_example.ipynb b/...sters/reindex_conversations_example.ipynb → ...sters/reindex_conversations_example.ipynb
diff --git a/tests/notebook_testers/rename_test.ipynb → .../tests/notebook_testers/rename_test.ipynb b/tests/notebook_testers/rename_test.ipynb → .../tests/notebook_testers/rename_test.ipynb
diff --git a/...ok_testers/test_corpus_partial_load.ipynb → ...ok_testers/test_corpus_partial_load.ipynb b/...ok_testers/test_corpus_partial_load.ipynb → ...ok_testers/test_corpus_partial_load.ipynb
diff --git a/..._testers/test_utterance_as_jsonlist.ipynb → ..._testers/test_utterance_as_jsonlist.ipynb b/..._testers/test_utterance_as_jsonlist.ipynb → ..._testers/test_utterance_as_jsonlist.ipynb
diff --git a/tests/run_all_tests.py → convokit/tests/run_all_tests.py b/tests/run_all_tests.py → convokit/tests/run_all_tests.py
diff --git a/tests/test_convo_traversal.py → convokit/tests/test_convo_traversal.py b/tests/test_convo_traversal.py → convokit/tests/test_convo_traversal.py
diff --git a/tests/test_corpus_index_meta.py → convokit/tests/test_corpus_index_meta.py b/tests/test_corpus_index_meta.py → convokit/tests/test_corpus_index_meta.py
diff --git a/tests/test_merge_corpus.py → convokit/tests/test_merge_corpus.py b/tests/test_merge_corpus.py → convokit/tests/test_merge_corpus.py
diff --git a/tests/test_utts_as_jsonlist.py → convokit/tests/test_utts_as_jsonlist.py b/tests/test_utts_as_jsonlist.py → convokit/tests/test_utts_as_jsonlist.py
@@ -1,9 +1,7 @@
 import unittest
 
 import os
-os.chdir("..")
 from convokit import Utterance, Corpus, Speaker
-os.chdir("./tests")
 
 class CorpusMerge(unittest.TestCase):
     def test_dump_and_load_with_binary(self):

diff --git a/convokit/tests/text_processing/__init__.py b/convokit/tests/text_processing/__init__.py