Front end #52
Merged
Front end #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhangtravis
requested changes
Nov 18, 2023
| @@ -13,26 +13,27 @@ import 'bootstrap/dist/css/bootstrap.css'; | |||
| // Internal component imports | |||
| import NavBar from './components/NavBar.js'; | |||
| import Home from './components/pages/Home.js'; | |||
| import ReturnPage from './components/pages/ReturnPage.js'; | |||
| // import ReturnPage from './components/pages/ReturnPage.js'; | |||
There was a problem hiding this comment.
Can you delete this comment please
| <Route exact path='/returnpage' element={<ReturnPage selectedFile={selectedFile}/>}/> | ||
| <Route exact path='/results' element={<Results />}/> | ||
| <Route exact path='/' element={<Home />} /> | ||
| {/* <Route exact path='/returnpage' element={<ReturnPage selectedFile={selectedFile} />} /> */} |
There was a problem hiding this comment.
If not used, please delete all comments!
Comment on lines
+38
to
+46
| // setLoading(true) | ||
| // await new Promise(resolve => setTimeout(resolve, 5000)); | ||
| // redirect() | ||
|
|
||
| // Send an API request with uploaded PDF blob | ||
| // Current request is a placeholder, replace with something else later | ||
| // const url = "http://mathsearch.org/api/send_request" | ||
| // const response = await fetch(url); | ||
|
|
There was a problem hiding this comment.
Delete these comments if not used
Comment on lines
+108
to
-46
| {/* <UploadPDFToS3WithNativeSdk /> */} | ||
| {/* <button onClick={handleClick}>Redirect to results</button> */} | ||
| {/* <button onClick={log_image}>log image!</button> */} | ||
| </div> | ||
| {/* <button onClick={log_image}>log image!</button> */} |
Comment on lines
+16
to
+36
| // const [loading, setLoading] = useState(false) | ||
| // const navigate = useNavigate() | ||
| // const redirect = async () => { | ||
| // // Test code | ||
| // // try { | ||
| // const url = "http://mathsearch.org/api/response_pdf"; | ||
| // const response = await fetch(url); | ||
| // // console.log("COOL") | ||
| // // console.log(response) | ||
| // const pdfBinary = await response.blob() | ||
|
|
||
| // const url2 = "http://mathsearch.org/api/response_pages" | ||
| // const response2 = await fetch(url2); | ||
| // const pages = await response2.json() | ||
| // // console.log(pages) | ||
| // // const iframe = document.createElement('iframe'); | ||
| // // iframe.src = `https://mozilla.github.io/pdf.js/web/viewer.html?file=${url}`; | ||
| // // document.body.appendChild(iframe); | ||
| // // } catch (err) { | ||
| // // console.log(err) | ||
| // // } |
There was a problem hiding this comment.
Delete these comments if not necessary. I want to reduce clutter :)
| // } catch (err) { | ||
| // console.log(err) | ||
| // } | ||
| // const test_api = async () => { |
|
TODO for Jason: Make sure to delete comments once everything works. I'll approve for now. |
zhangtravis
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.