fix(client): fix issue with navigation from a note with the forward/back keys #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-Authored-By: Luke Thomas <[email protected]>
|
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
CorentinTh
approved these changes
Oct 15, 2024
|
LGTM, great findings and thank you for the PR 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Media1.mp4
This issue happens as the global flag is set on the regex that tests the URL path.
And on Solid JS, the router seems to use
testto match the URL. Meaning it alternates betweentrueandfalse.Thanks to @Zoobdude for some help!