Increase default iteration count to 4096 for PBE PEM

Convex-Dev · Jan 29, 2024 · 6a275a0 · 6a275a0
1 parent 688173f
commit 6a275a0
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/convex-core/src/main/java/convex/core/crypto/PEMTools.java b/convex-core/src/main/java/convex/core/crypto/PEMTools.java
@@ -92,8 +92,9 @@ public static String encryptPrivateKeyToPEM(PrivateKey privateKey, char[] passwo
 		StringWriter stringWriter = new StringWriter();
 		JcaPEMWriter writer = new JcaPEMWriter(stringWriter);
 
-		JcePKCSPBEOutputEncryptorBuilder builder = new JcePKCSPBEOutputEncryptorBuilder(PKCS8Generator.PBE_SHA1_RC2_128);
 		try {
+			JcePKCSPBEOutputEncryptorBuilder builder = new JcePKCSPBEOutputEncryptorBuilder(PKCS8Generator.PBE_SHA1_RC2_128);
+			builder.setIterationCount(4096); // TODO: double check requirements here?
 			OutputEncryptor encryptor = builder.build(password);
 			JcaPKCS8Generator generator = new JcaPKCS8Generator(privateKey, encryptor);
 			writer.writeObject(generator);