More CLI paranoia tests

Convex-Dev · Jan 30, 2024 · 1220124 · 1220124
1 parent 375ede2
commit 1220124
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/convex-cli/src/main/java/convex/cli/key/KeyGenerate.java b/convex-cli/src/main/java/convex/cli/key/KeyGenerate.java
@@ -55,11 +55,14 @@ private AKeyPair generateKeyPair() {
 					if (cli().isInteractive()) {
 						passphrase=new String(cli().readPassword("Enter BIP39 passphrase: "));
 					} else {
+						cli().paranoia("Passphrase must be explicity provided");
 						passphrase="";
 					}
 				}
-				Blob bipseed;
-					bipseed = BIP39.getSeed(mnemonic, passphrase);
+				if (passphrase.isBlank()) {
+					cli().paranoia("Cannot use an empty passphrase for secure key generation");
+				}
+				Blob bipseed = BIP39.getSeed(mnemonic, passphrase);
 				AKeyPair result= BIP39.seedToKeyPair(bipseed);
 				return result;
 			} else {