fix: avoid useless io in large-payload queries #500
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When executing large-payload insert queries by POST, the current retry and throughput-limit mechanisms read the POST body, which can be resource-consuming and may even cause CPU/Memory bottlenecks. This MR avoids unnecessary I/O operations in these two mechanisms:
Closes #499, #428
Pull request type
Please check the type of change your PR introduces:
Checklist
Does this introduce a breaking change?
Further comments
For the throughput-limit mechanism: The
Content-Length
header indicates the size of the request body, so the throughput of GETs will be ignored. This is logical, as GETs typically have minimal impact on throughput compared to POSTs.